Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validate subnodes in validate IR #19831

Merged
merged 1 commit into from
Nov 17, 2024
Merged

fix: Validate subnodes in validate IR #19831

merged 1 commit into from
Nov 17, 2024

Conversation

ritchie46
Copy link
Member

fixes #18787

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Nov 17, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.34%. Comparing base (2a0d79b) to head (1249d14).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #19831   +/-   ##
=======================================
  Coverage   79.33%   79.34%           
=======================================
  Files        1548     1548           
  Lines      214193   214225   +32     
  Branches     2460     2460           
=======================================
+ Hits       169940   169979   +39     
+ Misses      43695    43688    -7     
  Partials      558      558

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit bb0b2a1 into main Nov 17, 2024
25 checks passed
@ritchie46 ritchie46 deleted the validate branch November 17, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.struct.field + .filter PanicException instead of ColumnNotFoundError
1 participant
@ritchie46