feat(rust): Allow specification of chunk_size on LazyCsvReader.read_options
#19819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engylemure
requested review from
ritchie46,
orlp and
c-peters
as code owners
engylemure
changed the title
engylemure
changed the title
LazyCsvReader.read_options
engylemure
changed the title
LazyCsvReader.read_optionsLazyCsvReader.read_options
github-actions
bot
added
enhancement
engylemure
changed the title
LazyCsvReader.read_optionschunk_size on LazyCsvReader.read_options
ritchie46
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LazyCsvReaderappears to consume significant memory for certain inputs. This is primarily due to the large defaultchunk_size(262144) in theCsvReadOptions. While thelow_memoryoption can help in some cases, it may not be sufficient for all use cases, introducing a way to control the amount of data that will be read and stored in memory can mitigate potential out-of-memory (OOM) issues at the cost of performance.Related issues:
collect()despite usinglimit(1)#17714