-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix incorrect filter after right-join on LazyFrame #19775
fix: Fix incorrect filter after right-join on LazyFrame #19775
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19775 +/- ##
=======================================
Coverage 79.55% 79.55%
=======================================
Files 1544 1544
Lines 213240 213243 +3
Branches 2441 2441
=======================================
+ Hits 169645 169648 +3
Misses 43046 43046
Partials 549 549 ☔ View full report in Codecov by Sentry. |
match how { | ||
JoinType::Left => LeftRight(false, true), | ||
JoinType::Full { .. } | JoinType::Cross => LeftRight(true, true), | ||
_ => LeftRight(false, false), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we forgot to update this function when we added Right
join, and it silently passed because of the _ =>
catch-all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't silently catch all. :|
Fixes #19772