-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: A different approach to warning users of fork() issues with Polars #19197
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19197 +/- ##
==========================================
- Coverage 80.03% 79.97% -0.06%
==========================================
Files 1528 1529 +1
Lines 209657 209822 +165
Branches 2416 2417 +1
==========================================
+ Hits 167791 167809 +18
- Misses 41317 41463 +146
- Partials 549 550 +1 ☔ View full report in Codecov by Sentry. |
The multiprocessing module warning is problematic when the module isn't directly used by the user. Some related discussions are happening in the PyTorch community (like pytorch/pytorch#138957). |
So using the Some other options:
|
I'm not arguing with I was trying to convey, that setting The way I see it, my suggestion does not affect regular users who will get the warning and hopefully will go read on the subject. |
Just print a warning when fork() is used at the same time as Polars, which is what
jax
does. Users aren't as likely to see warnings, but it's something, and it's less intrusive hopefully than the previous attempt that got reverted.