Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent raw npm publish #72

Merged
merged 2 commits into from
Jul 14, 2022
Merged

fix: prevent raw npm publish #72

merged 2 commits into from
Jul 14, 2022

Conversation

crisog
Copy link
Contributor

@crisog crisog commented Jul 14, 2022

As we are using PNPM as our package manager, we need to always publish using pnpm publish. If it was published with npm publish it would cause a dependency error (see v1.1.0).

This PR introduces a prepublish script to prevent direct npm publish commands.

@height
Copy link

height bot commented Jul 14, 2022

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@github-actions
Copy link

Size Change: 0 B

Total Size: 35.6 kB

ℹ️ View Unchanged
Filename Size
packages/abstract-provider/dist/index.js 1.47 kB
packages/abstract-provider/dist/index.umd.js 1.56 kB
packages/isomorphic-provider/dist/index.js 2.7 kB
packages/isomorphic-provider/dist/index.umd.js 2.84 kB
packages/pocket/dist/index.js 145 B
packages/pocket/dist/index.umd.js 236 B
packages/provider/dist/index.js 2.7 kB
packages/provider/dist/index.umd.js 2.83 kB
packages/relayer/dist/index.js 2.99 kB
packages/relayer/dist/index.umd.js 3.15 kB
packages/signer/dist/index.js 1.85 kB
packages/signer/dist/index.umd.js 2.02 kB
packages/transaction-builder/dist/index.js 4.59 kB
packages/transaction-builder/dist/index.umd.js 4.83 kB
packages/types/dist/index.js 357 B
packages/types/dist/index.umd.js 454 B
packages/utils/dist/index.js 339 B
packages/utils/dist/index.umd.js 496 B

compressed-size-action

@crisog crisog merged commit 2cc23ac into main Jul 14, 2022
@crisog crisog deleted the prevent-raw-publish branch July 14, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant