Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Library Evolution support for Xcode 16 #279

Merged

Conversation

gemmakbarlow
Copy link
Contributor

@gemmakbarlow gemmakbarlow commented Sep 24, 2024

  • Builds for Library Evolution support, and patches a small issue in this repository causing an issue for us, i.e. -

image

  • Adds Library Evolution support target replicating the issue to CI

Additional Notes
I noticed this comment; we're needing Library Evolution support for some beta apps we're working on using swift-dependencies.

Happy to assist with the maintenance, as far as it useful !

This partially reverts commit 4b65e03.

*waves* Hi - we’re depending on this.
“switch covers known cases, but 'AccessorBlockSyntax.Accessors' may have additional unknown values”
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for continuing to take the time to PR these!

This partially reverts commit 7c5590d.
@@ -50,6 +50,13 @@ build-for-library-evolution:
-Xswiftc -emit-module-interface \
-Xswiftc -enable-library-evolution

swift build \
Copy link
Contributor Author

@gemmakbarlow gemmakbarlow Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this really only covers Library Evolution on macOS, but is an improvement on what's currently running on CI.

@stephencelis
Copy link
Member

Thanks!

@stephencelis stephencelis merged commit 7101475 into pointfreeco:main Sep 25, 2024
5 checks passed
@gemmakbarlow gemmakbarlow deleted the gemmakbarlow/xcode-16-evolution branch September 29, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants