chore(): update rails to 6.1 #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjherrera
approved these changes
Oct 5, 2021
ldlsegovia
approved these changes
Oct 5, 2021
gmq
force-pushed
the
chore/update-rails
branch
from
27a8d17 to
8b5136d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpacker 4 is incompatible with the "newly" released webpack-dev-server@4, which may be breaking new projects created with potassium.
Updating Rails to 6.1 gives us access to Webpacker 5 which fixes the problem by fixing the version of the package to 3.
Mostly a placeholder until Webpacker 6 gets released, with compatibility with wds@4.
For existing projects: Upgrading to Rails 6.1 and Webpacker 5 seems to be seamless with our current setup, none of the changes should affect us but of course it depends on the project. Tested with mok and it worked as-is after running the update helper.