fix(frontend): use webpacker from rubygems #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackjid
approved these changes
Sep 3, 2019
|
Buena memo!, |
rjherrera
force-pushed
the
webpacker-fix
branch
from
5dffc5d to
f11cba3
Compare
monkeyci
reviewed
Sep 5, 2019
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Naming/FileName has the wrong namespace - should be Style
.rubocop.yml: Naming/FileName has the wrong namespace - should be Style .rubocop.yml: Naming/PredicateName has the wrong namespace - should be Style .rubocop.yml: Layout/EndAlignment has the wrong namespace - should be Lint .rubocop.yml: Layout/DefEndAlignment has the wrong namespace - should be Lint .rubocop.yml: Naming/AccessorMethodName has the wrong namespace - should be Style .rubocop.yml: Naming/AsciiIdentifiers has the wrong namespace - should be Style .rubocop.yml: Lint/FlipFlop has the wrong namespace - should be Style .rubocop.yml: Layout/BlockAlignment has the wrong namespace - should be Lint .rubocop.yml: Layout/ConditionPosition has the wrong namespace - should be Lint Warning: unrecognized cop Style/TrailingCommaInArrayLiteral found in .rubocop.yml Warning: unrecognized cop Style/TrailingCommaInHashLiteral found in .rubocop.yml Warning: unrecognized cop Naming/BinaryOperatorParameterName found in .rubocop.yml Warning: unrecognized cop Lint/LiteralAsCondition found in .rubocop.yml Warning: unrecognized cop RSpec/ExpectChange found in .rubocop.yml Error: Unknown Ruby version 2.5 found in `TargetRubyVersion` parameter (in .rubocop.yml). Known versions: 1.9, 2.0, 2.1, 2.2, 2.3, 2.4
rjherrera
approved these changes
Sep 5, 2019
ldlsegovia
approved these changes
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arregla error en creación de proyecto nuevo.
Se usa la última versión estable publicada en RubyGems en vez de confiar que el último commit de github es compatible con nuestro setup.