Improve IP address change IPv4 <-> IPv6 #3910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanangizz
approved these changes
Apr 1, 2024
trengginas
approved these changes
Apr 3, 2024
dshamaev-intermedia
pushed a commit
to intermedia-net/pjproject
that referenced
this pull request
Apr 4, 2024
dshamaev-intermedia
pushed a commit
to intermedia-net/pjproject
that referenced
this pull request
Apr 4, 2024
dshamaev-intermedia
added a commit
to intermedia-net/pjproject
that referenced
this pull request
Apr 4, 2024
* Add missing openssl SECLEVEL=0 support (pjsip#3890) Previous SECLEVEL support allowed for levels 1-5. However, openssl defines levels 0-5. [1] Recent openssl versions (3.0+) have moved previous popular ciphers/key lengths (i.e. RSA1024withSHA1) into level 0, so it is now a reasonable choice to use. Add support for level 0. [1] https://www.openssl.org/docs/man3.2/man3/SSL_CTX_set_security_level.html * Enable Late Offer Answer Mode (LOAM) feature in the pjsua (pjsip#3869) * Fix warnings for 32-bit compiler and misc fixes. (pjsip#3896) * Add some missing unlocks (pjsip#3893) * Prevent race condition in DTLS media stop (pjsip#3901) * Fix data race reported by ThreadSanitizer in caching pool (pjsip#3897) * Fixed Metal renderer memory leak (pjsip#3909) * Fixed DTLS clock stoppage race (pjsip#3905) * Improve IP address change IPv4 <-> IPv6 (pjsip#3910) --------- Co-authored-by: naf <naf@sdf.org> Co-authored-by: Goodicus <15110766+goodicus@users.noreply.github.com> Co-authored-by: Amilcar Ubiera <chopin952@gmail.com> Co-authored-by: Santiago De la Cruz <51337247+xhit@users.noreply.github.com> Co-authored-by: sauwming <ming@teluu.com> Co-authored-by: Nanang Izzuddin <nanang@teluu.com> Co-authored-by: dshamaev-intermedia <105777082+dshamaev-intermedia@users.noreply.github.com>
dshamaev-intermedia
added a commit
to intermedia-net/pjproject
that referenced
this pull request
Apr 5, 2024
* Add option to shutdown all transports on IP change (pjsip#3781) * pjsua_handle_ip_change: Added missing null check for on_ip_changed_progress callback (pjsip#3830) * Reset stored remote name in dialog (dlg->initial_dest) if transport is server. (pjsip#3783) * Prevent immediate tsx termination upon transport error (pjsip#3805) * Fixed issues when adding new media and deinitializing media (pjsip#3821) * Potential issues when IPv6 is disabled (pjsip#3835) * Improve IP address change IPv4 <-> IPv6 (pjsip#3910) * Add some missing unlocks (pjsip#3893) * add missing unlock (pjsip#3885) * Retransmit 2xx response when transport is closed (pjsip#3828) * Fixed account's route set update when modifying account (pjsip#3825) --------- Co-authored-by: Nanang Izzuddin <nanang@teluu.com> Co-authored-by: sauwming <ming@teluu.com> Co-authored-by: Santiago De la Cruz <51337247+xhit@users.noreply.github.com> Co-authored-by: Andreas Wehrmann <andreas-wehrmann@users.noreply.github.com> Co-authored-by: Riza Sulistyo <trengginas@users.noreply.github.com>
dshamaev-intermedia
added a commit
to intermedia-net/pjproject
that referenced
this pull request
Jun 12, 2024
* Add missing openssl SECLEVEL=0 support (pjsip#3890) Previous SECLEVEL support allowed for levels 1-5. However, openssl defines levels 0-5. [1] Recent openssl versions (3.0+) have moved previous popular ciphers/key lengths (i.e. RSA1024withSHA1) into level 0, so it is now a reasonable choice to use. Add support for level 0. [1] https://www.openssl.org/docs/man3.2/man3/SSL_CTX_set_security_level.html * Enable Late Offer Answer Mode (LOAM) feature in the pjsua (pjsip#3869) * Fix warnings for 32-bit compiler and misc fixes. (pjsip#3896) * Add some missing unlocks (pjsip#3893) * Prevent race condition in DTLS media stop (pjsip#3901) * Fix data race reported by ThreadSanitizer in caching pool (pjsip#3897) * Fixed Metal renderer memory leak (pjsip#3909) * Fixed DTLS clock stoppage race (pjsip#3905) * Improve IP address change IPv4 <-> IPv6 (pjsip#3910) * pjsua_acc: Fix warnings for comparison between ‘pjsua_nat64_opt’ and ‘enum pjsua_ipv6_use’ (pjsip#3915) * Fix to ext_fmts accessed out of stack scope. (pjsip#3916) * Add check in siprtp sample app for inactive audio media (pjsip#3927) * Add function to initialize MediaFormat audio & video (pjsip#3925) * Fixed incorrect SDP buffer length calculation (pjsip#3924) * Support Push Notification in iOS sample app (pjsip#3913) * Fixed PJSUA2 API to get/set Opus config (pjsip#3935) * Fix bad address length check in pj_ioqueue_sendto(). (pjsip#3941) * Fix warning of uninitialized value in fuzz-crypto (pjsip#3946) * Print log on successful send (pjsip#3942) * Fixed CI Mac build failure (pjsip#3947) * Update Android JNI audio dev to use 16bit PCM only (pjsip#3945) * Add TLS/SSL backend: Windows Schannel (pjsip#3867) * pjsip_find_msg: Log warning if Content-Length field not found (pjsip#3960) * Fix audiodev index (pjsip#3962) * Fix assertion on call hangup from DTMF callback (pjsip#3970) * Fix yaml error in github feature template (pjsip#3972) * Fix version string in Python setup (pjsip#3976) * Prevent pjmedia_codec_param.info.enc_ptime_denum division by zero in stream (pjsip#3975) --------- Co-authored-by: naf <naf@sdf.org> Co-authored-by: Goodicus <15110766+goodicus@users.noreply.github.com> Co-authored-by: Amilcar Ubiera <chopin952@gmail.com> Co-authored-by: Santiago De la Cruz <51337247+xhit@users.noreply.github.com> Co-authored-by: sauwming <ming@teluu.com> Co-authored-by: Nanang Izzuddin <nanang@teluu.com> Co-authored-by: dshamaev-intermedia <105777082+dshamaev-intermedia@users.noreply.github.com> Co-authored-by: CI Bot <noreply@intermedia.com> Co-authored-by: Pau Espin Pedrol <pespin.shar@gmail.com> Co-authored-by: Riza Sulistyo <trengginas@users.noreply.github.com> Co-authored-by: Andreas Peldszus <andreas.peldszus@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IP address change wiki: https://docs.pjsip.org/en/latest/specific-guides/network_nat/ip_change.html
The PR contains several improvements:
Notes: to maintain ongoing calls, update to RTP/RTCP address and update dialog’s Contact is needed using re-INVITE. However sending re-INVITE might fail when route set is still using IPv4 (e.g: Record-route returned contains IPv4). In this case, forcefully disconnect the call is recommended.Unfortunately this means that a lot of calls will be broken upon IP change. The proposed solution here is that if
pjsip_get_dest_info()returns an address that mismatches the IP address version transport config, we revert back to usingdlg->initial_destto allow resolving the address again when sending re-INVITE.Currently, our wiki recommends calling
pjsua_acc_modify()followed bypjsua_handle_ip_address_change(). This causes the registration sent bypjsua_acc_modify()to fail because it still uses the old transport. The solution is to adddisable_reg_on_modifyfield, that allows disabling sending registration upon account modification.