Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix issue at new Node versions #350

Merged
merged 1 commit into from
Jun 9, 2023
Merged

test: fix issue at new Node versions #350

merged 1 commit into from
Jun 9, 2023

Conversation

metcoder95
Copy link
Member

The PR adjusts some tests that was leading to failures at most recent Node.js versions (i.e. 20 and 18)

@metcoder95 metcoder95 requested review from jasnell and RafaelGSS June 9, 2023 09:04
@RafaelGSS RafaelGSS merged commit d2051fb into next Jun 9, 2023
@RafaelGSS
Copy link
Member

I think we should create an issue to 'support 16, 18 and 20' and eventually perform a major release dropping support to v14 and previous versions.

@metcoder95 metcoder95 deleted the fix/18_20_support branch June 9, 2023 21:42
@metcoder95
Copy link
Member Author

Done, made #352 out of your comment 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants