Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazel to 4.0.0 #1893

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Update bazel to 4.0.0 #1893

merged 1 commit into from
Apr 21, 2021

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Apr 21, 2021

What this PR does / why we need it:

The next PRs will update rules_go, rules_docker as well.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.15%. This pull request decreases coverage by -0.02%.

File Function Base Head Diff
pkg/app/piped/logpersister/stagelogpersister.go stageLogPersister.flushFromLastCheckpoint 61.11% 50.00% -11.11%

@khanhtc1202
Copy link
Member

🚀
/lgtm

@khanhtc1202
Copy link
Member

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 3b9d3e6 into master Apr 21, 2021
@pipecd-bot pipecd-bot deleted the update-bazel branch April 21, 2021 02:27
nakabonne added a commit that referenced this pull request Apr 22, 2021
nakabonne added a commit that referenced this pull request Apr 22, 2021
pipecd-bot pushed a commit that referenced this pull request Apr 22, 2021
This reverts commit 3b9d3e6.

**What this PR does / why we need it**:
From #1901

#1902 can take a little bit long time. So to workaround we can revert it.

**Which issue(s) this PR fixes**:

Fixes #

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants