Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ttl: delWorker maybe blocked forever in concurrency #58484

Closed
lcwangchao opened this issue Dec 23, 2024 · 0 comments · Fixed by #58485
Closed

ttl: delWorker maybe blocked forever in concurrency #58484

lcwangchao opened this issue Dec 23, 2024 · 0 comments · Fixed by #58485
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@lcwangchao
Copy link
Collaborator

See gouroutine

goroutine 810 [select, 328 minutes]:
golang.org/x/time/rate.(*Limiter).wait(0xc000bbc730, {0x70fa448, 0xc002d77da0}, 0x1, {0x4a2cdb1?, 0x679ca4a?, 0xab0d780?}, 0x69d6ec0)
	/root/go/pkg/mod/golang.org/x/time@v0.7.0/rate/rate.go:286 +0x3f3
golang.org/x/time/rate.(*Limiter).WaitN(0xc000bbc730, {0x70fa448, 0xc002d77da0}, 0x1)
	/root/go/pkg/mod/golang.org/x/time@v0.7.0/rate/rate.go:249 +0x50
golang.org/x/time/rate.(*Limiter).Wait(...)
	/root/go/pkg/mod/golang.org/x/time@v0.7.0/rate/rate.go:234
github.com/pingcap/tidb/pkg/ttl/ttlworker.(*defaultDelRateLimiter).WaitDelToken(0xc002d60680?, {0x70fa448?, 0xc002d77da0?})
	/workspace/source/tidb/pkg/ttl/ttlworker/del.go:72 +0x73
github.com/pingcap/tidb/pkg/ttl/ttlworker.(*ttlDeleteTask).doDelete(0xc015b24d20, {0x70fa448, 0xc002d77da0}, {0x719ac00, 0xc002d767e0})
	/workspace/source/tidb/pkg/ttl/ttlworker/del.go:139 +0x389
github.com/pingcap/tidb/pkg/ttl/ttlworker.(*ttlDeleteWorker).loop(0xc002a7ec00)
	/workspace/source/tidb/pkg/ttl/ttlworker/del.go:396 +0x46f
github.com/pingcap/tidb/pkg/ttl/ttlworker.(*baseWorker).loop(0x0?)
	/workspace/source/tidb/pkg/ttl/ttlworker/worker.go:136 +0x53
github.com/pingcap/tidb/pkg/util.(*WaitGroupWrapper).Run.func1()
	/workspace/source/tidb/pkg/util/wait_group_wrapper.go:157 +0x4c
created by github.com/pingcap/tidb/pkg/util.(*WaitGroupWrapper).Run in goroutine 828
	/workspace/source/tidb/pkg/util/wait_group_wrapper.go:155 +0x73
@lcwangchao lcwangchao added type/bug The issue is confirmed as a bug. severity/major labels Dec 23, 2024
@lcwangchao lcwangchao added the affects-7.1 This bug affects the 7.1.x(LTS) versions. label Dec 23, 2024
@lcwangchao lcwangchao added affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. type/bug The issue is confirmed as a bug. sig/sql-infra SIG: SQL Infra severity/major and removed type/bug The issue is confirmed as a bug. severity/major may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 affects-7.1 This bug affects the 7.1.x(LTS) versions. may-affects-8.1 may-affects-8.5 may-affects-7.5 labels Dec 23, 2024
@ti-chi-bot ti-chi-bot bot added may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
1 participant