Improve wording when --skip-enable-extension #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `--skip-enable-extension` is used, it's done on purpose. No need to uppercase not. Explain how the extension can be enabled.
asgrim
reviewed
Jan 7, 2025
| @@ -42,9 +42,9 @@ public function __invoke( | |||
| $output->writeln('Automatic extension enabling was skipped.', OutputInterface::VERBOSITY_VERBOSE); | |||
| } | |||
|
|
|||
| $output->writeln('<comment>⚠️ Extension has NOT been automatically enabled.</comment>'); | |||
| $output->writeln('<comment>⚠️ Extension is not enabled.</comment>'); | |||
There was a problem hiding this comment.
This messaging is not only emitted when --skip-enable-extension is used; it is also when we failed to automatically enable the extension. The messaging on the line above (Automatic extension enabling was skipped.) provides the context, although only with verbose mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--skip-enable-extensionis used, it's done on purpose.No need to uppercase not.
Explain how the extension can be enabled.