Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wording when --skip-enable-extension #172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve wording when --skip-enable-extension #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Installing/SetupIniFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ public function __invoke(
$output->writeln('Automatic extension enabling was skipped.', OutputInterface::VERBOSITY_VERBOSE);
}

$output->writeln('<comment>⚠️ Extension has NOT been automatically enabled.</comment>');
$output->writeln('<comment>⚠️ Extension is not enabled.</comment>');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This messaging is not only emitted when --skip-enable-extension is used; it is also when we failed to automatically enable the extension. The messaging on the line above (Automatic extension enabling was skipped.) provides the context, although only with verbose mode.

$output->writeln(sprintf(
'<comment>You must now add "%s=%s" to your php.ini</comment>',
'<comment>Add "%s=%s" to your php.ini to enable this extension.</comment>',
$downloadedPackage->package->extensionType === ExtensionType::PhpModule ? 'extension' : 'zend_extension',
$downloadedPackage->package->extensionName->name(),
));
Expand Down