Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and cleanups #4

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Bugfixes and cleanups #4

merged 3 commits into from
Jan 6, 2023

Conversation

amrox
Copy link
Contributor

@amrox amrox commented Jan 2, 2023

Thank you for sharing this script! I had to edit it a bit so it worked with my note export. I hope you find the changes useful.

amrox added 3 commits January 2, 2023 15:35
- remove unnecessary 'is True' comparisons
- add/remove blank lines
also add some additional logging
@philgyford
Copy link
Owner

Thanks for this. I should have thought about moving the sanitisation before the check for duplicates!

I've always preferred being explicit about boolean comparisons, so if foo is True: rather than just if foo: but I see PEP8 seems to prefer the latter so fair enough!

@philgyford philgyford merged commit 631266b into philgyford:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants