Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache base64 resources #1848

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Cache base64 resources #1848

merged 2 commits into from
Jan 23, 2025

Conversation

ninadbstack
Copy link
Contributor

Changes:

  • Now we cache data src resources - is helpful in some cases where we were getting hundreds of repeated resources as those were on different dom nodes
  • We now set src on cloned node using data-percy-serialized-attribute-src - which is later replaced with src. This allows us to avoid network call that browser makes when we set src on any cloned node.

@ninadbstack ninadbstack requested a review from a team as a code owner January 22, 2025 12:17
@ninadbstack ninadbstack force-pushed the cache-base64-resources branch from 415145b to 55b9e26 Compare January 22, 2025 12:35
rishigupta1599
rishigupta1599 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@rishigupta1599 rishigupta1599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pankaj443
pankaj443 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@pankaj443 pankaj443 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ninadbstack ninadbstack added 🐛 bug Something isn't working ✨ enhancement New feature or request labels Jan 23, 2025
@ninadbstack ninadbstack merged commit 2a73e80 into master Jan 23, 2025
36 checks passed
@ninadbstack ninadbstack deleted the cache-base64-resources branch January 23, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankaj443 pankaj443 pankaj443 approved these changes

@rishigupta1599 rishigupta1599 rishigupta1599 approved these changes

@prklm10 prklm10 Awaiting requested review from prklm10 prklm10 is a code owner automatically assigned from percy/percy-product-reviewers

@shantanuk-browserstack shantanuk-browserstack Awaiting requested review from shantanuk-browserstack shantanuk-browserstack is a code owner automatically assigned from percy/percy-product-reviewers

Assignees
No one assigned
Labels
🐛 bug Something isn't working ✨ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ninadbstack @pankaj443 @rishigupta1599