-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated chromium revisions for 126 #1828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0dd10f
to
88a00be
Compare
88a00be
to
3ab6ae2
Compare
7dcfe32
to
e71b874
Compare
71f3fde
to
d742f27
Compare
90df87d
to
7c61001
Compare
7c61001
to
288517d
Compare
…1814) * updated snapshot concurrency * Removing the build script * lint fix * Fixing few cases * 🔖 v1.31.0-alpha.0 * 🔖 v1.31.0-alpha.0 lerna.json * Adding Error Capturing on Finalize Builds (#1818) * Adding Error Capturing on Finalize Builds * 🔖 v1.31.0-alpha.1 * 🔖 v1.31.0-alpha.2 * Adding prodBuild param for scanner alt env (#1830) * Adding prodBuild param for scanner alt env * renaming config --------- Co-authored-by: rishigupta1599 <114384996+rishigupta1599@users.noreply.github.com> * 🔖 v1.31.0-alpha.0 lerna.json * Removing unwanted files * 🔖 v1.31.0-alpha.3 * Add tests + fix concurrency * Undo package json changes --------- Co-authored-by: amit3200 <tusharamit@yahoo.com> Co-authored-by: rishigupta1599 <114384996+rishigupta1599@users.noreply.github.com> Co-authored-by: rishigupta1599 <rishi@browserstack.com> Co-authored-by: Chinmay Maheshwari <chinmay.m@browserstack.com>
* Release v1.30.6-beta.0 * Update tag to beta
* PAC file support via PERCY_PAC_FILE_URL env var (#1784) * PAC file support via PERCY_PAC_FILE_PATH env var * Added pac-proxy-agent lib as dependency * typo fixes * PR comments addressed * Moved pac-proxy-agent lib dependency to percy client instead of main package * Resolved conflicts * Fix import in ternary statement (#1779) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * Removed trailing space --------- Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * v1.30.3-alpha.0 * Cli bundling import fix (#1785) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * Removed trailing space * Fix import of PERCY_DOM in line w ESM req * made a minor comment change --------- Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * v1.30.3-alpha.1 * v1.30.3-alpha.2 * Cli bundling import fix (#1794) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * Removed trailing space * Fix import of PERCY_DOM in line w ESM req * made a minor comment change * Added PERCY_FORCE_DIRNAME flag in getPackageJSON util method * Env var name updated to PERCY_FORCE_EXECUTABLE_DIRNAME Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> --------- Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * v1.30.3-alpha.3 * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME (#1799) * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME * Bumped the percy tag to 1.30.3-alpha.4 * Added PERCY_FORCE_PKG_VALUE in env file and using from there (#1800) * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME * Bumped the percy tag to 1.30.3-alpha.4 * Added PERCY_FORCE_PKG_VALUE in env file and using from there * Bumped the percy tag to 1.30.3-alpha.5 * fixed linting * client-fix * upload-cli-fix * cli-build-fix * cli-exec-fix * cli-snapshot-fix * MERGE_COMMIT * MERGE_COMMIT * Proxy.test * proxy * core fixed * client package * client package * client package * client package * client package * lock file * pac-packages * pac-packages * pac-packages * lint pass * lint pass * lint pass * lint pass * proxy pass * client pass * api-test * api-test * percy-test-cases * Removed find revision * lint-fix --------- Co-authored-by: Khushhal Maheshwari <25052873+khushhalm@users.noreply.github.com> Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> Co-authored-by: Ninad Sheth <ninad@browserstack.com> Co-authored-by: prklm10 <pradumraj360@gmail.com> Co-authored-by: Mukul Bhutiani <mukul.b@browserstack.com>
* PAC file support via PERCY_PAC_FILE_URL env var (#1784) * PAC file support via PERCY_PAC_FILE_PATH env var * Added pac-proxy-agent lib as dependency * typo fixes * PR comments addressed * Moved pac-proxy-agent lib dependency to percy client instead of main package * Resolved conflicts * Fix import in ternary statement (#1779) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * Removed trailing space --------- Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * v1.30.3-alpha.0 * Cli bundling import fix (#1785) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * Removed trailing space * Fix import of PERCY_DOM in line w ESM req * made a minor comment change --------- Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * v1.30.3-alpha.1 * v1.30.3-alpha.2 * Cli bundling import fix (#1794) * Fix import in ternary statement * Added comment * Typo fix in comment Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * Removed trailing space * Fix import of PERCY_DOM in line w ESM req * made a minor comment change * Added PERCY_FORCE_DIRNAME flag in getPackageJSON util method * Env var name updated to PERCY_FORCE_EXECUTABLE_DIRNAME Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> --------- Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> * v1.30.3-alpha.3 * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME (#1799) * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME * Bumped the percy tag to 1.30.3-alpha.4 * Added PERCY_FORCE_PKG_VALUE in env file and using from there (#1800) * Added PERCY_FORCE_PKG_VALUE in place of PERCY_FORCE_DIRNAME * Bumped the percy tag to 1.30.3-alpha.4 * Added PERCY_FORCE_PKG_VALUE in env file and using from there * Bumped the percy tag to 1.30.3-alpha.5 * fixed linting * client-fix * upload-cli-fix * cli-build-fix * cli-exec-fix * cli-snapshot-fix * MERGE_COMMIT * MERGE_COMMIT * Proxy.test * proxy * core fixed * client package * client package * client package * client package * client package * lock file * pac-packages * pac-packages * pac-packages * lint pass * lint pass * lint pass * lint pass * proxy pass * client pass * api-test * api-test * percy-test-cases * Removed find revision * lint-fix --------- Co-authored-by: Khushhal Maheshwari <25052873+khushhalm@users.noreply.github.com> Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> Co-authored-by: Ninad Sheth <ninad@browserstack.com> Co-authored-by: prklm10 <pradumraj360@gmail.com> Co-authored-by: Mukul Bhutiani <mukul.b@browserstack.com>
dd1d101
to
5b8ba6b
Compare
0c9f2ea
to
54304c9
Compare
packages/core/test/discovery.test.js
Outdated
@@ -1763,7 +1762,6 @@ describe('Discovery', () => { | |||
}); | |||
|
|||
await percy.idle(); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readd this
3dcfa3c
to
86aaf9e
Compare
dd3776d
to
06baaac
Compare
06baaac
to
22150c5
Compare
97240a7
to
2355463
Compare
RonakAghera
approved these changes
Jan 17, 2025
pankaj443
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated chromium revisions for 126
base branch position 1300313
new versions
chromium.revisions = {
linux: '1300309',
win64: '1300297',
win32: '1300295',
darwin: '1300293',
darwinArm: '1300314'
};
Testing: