Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: fix enum parsing in hictk CLI code #332

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

robomics
Copy link
Contributor

Fixes #331.

@robomics robomics added the bug Something isn't working label Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.70%. Comparing base (88c6384) to head (0dc175e).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   81.82%   81.70%   -0.12%     
==========================================
  Files         231      231              
  Lines       28169    28233      +64     
  Branches     3470     3478       +8     
==========================================
+ Hits        23050    23069      +19     
- Misses       3844     3886      +42     
- Partials     1275     1278       +3     
Flag Coverage Δ
[tests integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/332/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 67.83% <ø> (-0.11%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/332/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 81.77% <ø> (-0.03%)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit 7bbb2f1 into main Feb 21, 2025
133 of 134 checks passed
@robomics robomics deleted the fix/cli-str-to-enum branch February 21, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dump the .hic file with --matrix-type parameter facing an error report
1 participant