Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to hictk rename-chromosomes #232

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

robomics
Copy link
Contributor

This edge case was detected while developing #217.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.83%. Comparing base (ff82e76) to head (4c017ed).
Report is 4 commits behind head on main.

Files Patch % Lines
...rc/hictk/rename_chromosomes/rename_chromosomes.cpp 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   75.85%   75.83%   -0.02%     
==========================================
  Files         140      140              
  Lines       11580    11584       +4     
  Branches     1311     1311              
==========================================
+ Hits         8784     8785       +1     
- Misses       1717     1720       +3     
  Partials     1079     1079              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[no ci]
@robomics robomics merged commit 9401d15 into main Aug 27, 2024
@robomics robomics deleted the fix/rename-chroms branch August 27, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant