Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to hictk dump #229

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Minor improvements to hictk dump #229

merged 3 commits into from
Aug 26, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Aug 26, 2024

The endless loop was detected while developing #217.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 36 lines in your changes missing coverage. Please review.

Project coverage is 75.65%. Comparing base (ff82e76) to head (10a28e0).
Report is 4 commits behind head on main.

Files Patch % Lines
src/hictk/dump/dump_common.cpp 30.00% 29 Missing and 6 partials ⚠️
src/hictk/dump/dump.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   75.85%   75.65%   -0.21%     
==========================================
  Files         140      140              
  Lines       11580    11615      +35     
  Branches     1311     1321      +10     
==========================================
+ Hits         8784     8787       +3     
- Misses       1717     1745      +28     
- Partials     1079     1083       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit e920ef2 into main Aug 26, 2024
51 of 53 checks passed
@robomics robomics deleted the feat/improve-dump branch August 26, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant