Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements and bug fixes to code related to fetching interactions as Eigen matrices #227

Merged
merged 10 commits into from
Aug 29, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Aug 25, 2024

These bugs were discovered while developing #226.

Fix a bug that could cause the result of certain queries partially
overlapping with the matrix diagonal, to be incomplete.
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 83.49515% with 17 lines in your changes missing coverage. Please review.

Project coverage is 75.48%. Comparing base (ff82e76) to head (9875298).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
.../hictk/transformers/impl/to_sparse_matrix_impl.hpp 79.48% 8 Missing ⚠️
...hic/include/hictk/hic/impl/pixel_selector_impl.hpp 0.00% 7 Missing ⚠️
...transformers/include/hictk/transformers/common.hpp 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   75.85%   75.48%   -0.38%     
==========================================
  Files         140      141       +1     
  Lines       11580    11685     +105     
  Branches     1311     1330      +19     
==========================================
+ Hits         8784     8820      +36     
- Misses       1717     1774      +57     
- Partials     1079     1091      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics changed the title Fix various bugs when fetching interactions as Eigen matrices Various improvements and bug fixes to code related to fetching interactions as Eigen matrices Aug 27, 2024
@robomics robomics merged commit f87584b into main Aug 29, 2024
52 checks passed
@robomics robomics deleted the fix/matrices branch August 29, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant