This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
test-utils: Fix wait_for_blocks in presence of reorgs #14215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the cases where a reorg happens we might receive notifications for different blocks at the same level, so instead of the chain having count new blocks it has less and that will break the tests which use this function. So, use the block number to identify that `count` blocks have been built in the chain. Examples where this issue was hit: paritytech/polkadot#7267 Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
bkchr
approved these changes
May 24, 2023
alexggh
added
A0-please_review
tdimitrov
approved these changes
May 26, 2023
|
bot merge |
Ank4n
pushed a commit
that referenced
this pull request
Jul 8, 2023
In the cases where a reorg happens we might receive notifications for different blocks at the same level, so instead of the chain having count new blocks it has less and that will break the tests which use this function. So, use the block number to identify that `count` blocks have been built in the chain. Examples where this issue was hit: paritytech/polkadot#7267 Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
In the cases where a reorg happens we might receive notifications for different blocks at the same level, so instead of the chain having count new blocks it has less and that will break the tests which use this function. So, use the block number to identify that `count` blocks have been built in the chain. Examples where this issue was hit: paritytech/polkadot#7267 Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cases where a reorg happens we might receive notifications for different blocks at the same level, so instead of the chain having
countnew blocks it has less and that will break the tests which use this function.So, use the block number to identify that
countblocks have been built in the chain.Examples where this issue was hit:
paritytech/polkadot#7267