Added required score grouping to fellows reviews #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Values have been hardcoded to the given ranks as a more "leaner" way to understand which rank is which. We have pre-emptively added ranks up to dan IX.
That fixed the problems with the tests
|
Example of error message: Score ruleMissing minimum required score from FellowsRule explanationRule 'Fellows' gives every fellow a score based on their rank, and required that the sum of all the scores is greater than the required score.For more info found out how the rules work in Review-bot types Missing a score of 5Missing 1 in the required score. GitHub users whose approval countsThis is a list of all the Fellows that have not reviewed with their current scores:Users approvals that counted towards this rule with their scores
|
With new fellows the timeout requires to be longer. Extended by 10 seconds
mordamax
reviewed
Jan 29, 2024
| case 8: | ||
| return scores.dan8; | ||
| case 9: | ||
| return scores.dan9; |
There was a problem hiding this comment.
could be just return scores['dan' + rank] ?
There was a problem hiding this comment.
I'm afraid not unless I convert the object into a collection of keys which I think would make it unreadable.
I prefer to add more lines if they are easier to read than to complicate the code for the sake of reducing its size.
Bullrich
force-pushed
the
fellows-score
branch
from
dcdf564 to
b2b80cf
Compare
Jest Test ResultsDuration: 44.257 seconds
Outcome: Passed | Total Tests: 159 | Passed: 159 | Failed: 0
|
Bullrich
force-pushed
the
fellows-score
branch
from
b2b80cf to
4bd69c4
Compare
rzadp
approved these changes
Jan 29, 2024
mordamax
approved these changes
Jan 29, 2024
This was referenced Jan 29, 2024
fellowship-merge-bot bot
pushed a commit
to polkadot-fellows/runtimes
that referenced
this pull request
Feb 14, 2024
Updated Review Bot to version 2.4.0 which contains paritytech/review-bot#110 (solved in paritytech/review-bot#113) This resolves #93 Updated review bot to latest version which brings new changes to the fellow object: Added new optional field to the config named `scores` that has the score of each fellow per dan (added up to dan IX). When the rule of type `fellows` has the optional field of `minTotalScore` it will check that the score of the fellows who approved the PR sums up to that number. If it doesn't sum to that number it will fail with a custom error listing the score of each fellow for reference (and saying how many points are missing). Find a complete explanation of the new configuration here: [Fellows Rule](/~https://github.com/paritytech/review-bot/blob/v2.4.0/README.md#fellows-rule) - [x] Does not require a CHANGELOG entry I also added some scores to all the dans (feel free to modify them) and updated the `Relay and system files` rule to have a minimum score of 6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new optional field to the config named
FellowScoresthat has the score of each fellow per dan. It was done as an object (and not a collection) because it will never change in the foreseeable future (added up to dan IX).When the rule of type
fellowshas the optional field ofminTotalScoreit will check that the score of the fellows who approved the PR sums up to that number. If it doesn't sum to that number it will fail with a custom error listing the score of each fellow for reference (and saying how many points are missing).Added
FellowMissingScoreFailureclass which handles the formatting of errors when the score of fellows is not high enough.This resolves #110
Downgraded JOI as there was a version mismatch that made the test fails.