Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Enable logging in the puppet worker #3411

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Enable logging in the puppet worker #3411

merged 1 commit into from
Jul 5, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Jul 5, 2021

This is useful for tests where something is failing :D

@bkchr
Enable logging in the puppet worker
6143e91 
This is useful for tests where something is failing :D
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 5, 2021
@bkchr bkchr requested a review from pepyakin July 5, 2021 11:47
pepyakin
pepyakin approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise this looks trivially good. I cannot tell if this has the intended effect though.

@bkchr
Copy link
Member Author

bkchr commented Jul 5, 2021

Codewise this looks trivially good. I cannot tell if this has the intended effect though.

Yeah it has. I'm currently facing such a situation :(

@bkchr bkchr merged commit ade2058 into master Jul 5, 2021
@bkchr bkchr deleted the bkchr-tracing-in-puppet-worker branch July 5, 2021 12:18
ordian added a commit that referenced this pull request Jul 6, 2021
@ordian
Merge branch 'master' into rh-chain-selection-db-and-stagnant
8feb436 
* master: (33 commits)
  Update all weights, add run_all_benches.sh script (#3400)
  Enable over-bridge-messaging in Rococo/Wococo runtime (#3377)
  paras.rs to FRAME V2 (#3403)
  Add XCM Tracing (#3353)
  Use MaxEncodedLen trait from new parity-scale-codec v2.2 (#3412)
  bump a bunch of deps in parity-common (#3402)
  Warn on low connectivity. (#3408)
  origin to frame v2 (#3405)
  Enable logging in the puppet worker (#3411)
  make it easier to dbg stalls (#3351)
  XCM `canonicalize` + `prepend_with` fix (#3269)
  cleanup stream polls (#3397)
  Staking Miner (#3141)
  Companion for Substrate#8953 (#3140)
  Bump version, specs & substrate in prep for v0.9.8 (#3387)
  Fix busy loops. (#3392)
  Minor refactor (#3386)
  add simnet tests (#3381)
  BEEFY: adjust gossip (#3372)
  Companion for #9193 (#3376)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pepyakin pepyakin pepyakin approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkchr @pepyakin