This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use wasm-builder from git #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings new features like compressed runtimes out of the box.
bkchr
added
A2-insubstantial
|
We probably also want to bump up the 2 dependencies under |
Feel free to open a PR in the bridges repo with this change. All our Substrate dependencies are Git based anyways, so I don't think this will be an issue |
TestsI tested the build of a few runtimes:
The tests are run with NOTE: I skipped the bridges tests as the code is not current (Millau failed here but the issue is fixed in the bridges repo). |
chevdor
reviewed
Jun 23, 2021
| let blob = prevalidate(code)?; | ||
| let code = sp_maybe_compressed_blob::decompress(code, 10 * 1024 * 1024).expect("Decompressing code failed"); | ||
|
|
||
| let blob = prevalidate(&*code)?; |
There was a problem hiding this comment.
Do we need this explicit deref ?
chevdor
approved these changes
Jun 23, 2021
chevdor
added a commit
to chevdor/parity-bridges-common
that referenced
this pull request
Jun 23, 2021
pepyakin
approved these changes
Jun 24, 2021
Co-authored-by: Sergei Shulepov <sergei@parity.io>
chevdor
added a commit
to paritytech/parity-bridges-common
that referenced
this pull request
Jun 25, 2021
* chore: update the wasm builder to substrate master * Bump Substrate * Update weight of sending remarks ref paritytech/polkadot#3354 Co-authored-by: Hernando Castano <hernando@hcastano.com>
ordian
added a commit
that referenced
this pull request
Jul 2, 2021
* master: (21 commits) cleanup stream polls (#3397) Staking Miner (#3141) Companion for Substrate#8953 (#3140) Bump version, specs & substrate in prep for v0.9.8 (#3387) Fix busy loops. (#3392) Minor refactor (#3386) add simnet tests (#3381) BEEFY: adjust gossip (#3372) Companion for #9193 (#3376) Companion for Decouple Staking and Election - Part 3: Signed Phase (#2793) Ensure that we fetch another collation if the first collation was invalid (#3362) Only send one collation per relay parent at a time to validators (#3360) disable approval-checking-grandpa on dev chain (#3364) Use associated constant for max (#3375) Use wasm-builder from git (#3354) Squashed 'bridges/' changes from b2099c5..23dda62 (#3369) Bump versions & spec_versions (#3368) Don't allow bids for a ParaId where there is an overlapping lease period (#3361) Companion for upgrade of transaction-payment to pallet macro (#3267) Do not allow any crowdloan contributions during the VRF period (#3346) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings new features like compressed runtimes out of the box.