[eth-indexer] subscribe to finalize blocks instead of best blocks #7260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cmd prdoc --audience runtime_dev --bump minor |
pgherveou
added
T7-smart_contracts
xermicus
approved these changes
Jan 20, 2025
athei
reviewed
Jan 20, 2025
| @@ -324,7 +336,7 @@ impl Client { | |||
| let client = self.clone(); | |||
| spawn_handle.spawn("subscribe-blocks", None, async move { | |||
| let res = client | |||
| .subscribe_new_blocks(|block| async { | |||
| .subscribe_new_blocks(SubscriptionType::BestBlocks, |block| async { | |||
There was a problem hiding this comment.
Why are we not using finalized here?
There was a problem hiding this comment.
that for the "in memory" cache maintained by the eth-rpc. In Ethereum you don't wait for the block to be finalized when you call the RPC, so I am not waiting for finalized blocks here. We could decide to wait for the finalized block but that would also impact the user's experience, you will see MM spinning for much longer.
There was a problem hiding this comment.
Okay no its fine then. It wasn't apparent from the function names.
athei
approved these changes
Jan 20, 2025
Nathy-bajo
pushed a commit
to Nathy-bajo/polkadot-sdk
that referenced
this pull request
Jan 21, 2025
…ritytech#7260) For eth-indexer, it's probably safer to use `subscribe_finalized` and index these blocks into the DB rather than `subscribe_best` --------- Co-authored-by: command-bot <>
Nathy-bajo
pushed a commit
to Nathy-bajo/polkadot-sdk
that referenced
this pull request
Jan 21, 2025
…ritytech#7260) For eth-indexer, it's probably safer to use `subscribe_finalized` and index these blocks into the DB rather than `subscribe_best` --------- Co-authored-by: command-bot <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For eth-indexer, it's probably safer to use
subscribe_finalizedand index these blocks into the DB rather thansubscribe_best