Clear other messages before dry-run to get only the ones produced during #5581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
reviewed
Sep 4, 2024
franciscoaguirre
commented
Sep 4, 2024
|
The CI pipeline was cancelled due to failure one of the required jobs. |
ggwpez
approved these changes
Sep 4, 2024
ggwpez
added
the
A4-needs-backport
acatangiu
approved these changes
Sep 5, 2024
Co-authored-by: Adrian Catangiu <adrian@parity.io>
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-5581-to-stable2407
git worktree add --checkout .worktree/backport-5581-to-stable2407 backport-5581-to-stable2407
cd .worktree/backport-5581-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 8d9ebcd51a8021f77d6ae16ef9d6388f55d0598f
git push --force-with-lease |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
…ing (#5581) The dry-run shows in `forwarded_xcms` all the messages in the queues at the time of calling the API. Each time the API is called, the result could be different. You could get messages even if you dry-run something that doesn't send a message, like a `System::remark`. This PR fixes this by clearing the message queues before doing the dry-run, so the only messages left are the ones the users of the API actually care about. --------- Co-authored-by: Adrian Catangiu <adrian@parity.io> (cherry picked from commit 8d9ebcd)
|
Successfully created backport PR for |
franciscoaguirre
added a commit
that referenced
this pull request
Sep 5, 2024
…ing (#5581) The dry-run shows in `forwarded_xcms` all the messages in the queues at the time of calling the API. Each time the API is called, the result could be different. You could get messages even if you dry-run something that doesn't send a message, like a `System::remark`. This PR fixes this by clearing the message queues before doing the dry-run, so the only messages left are the ones the users of the API actually care about. --------- Co-authored-by: Adrian Catangiu <adrian@parity.io> (cherry picked from commit 8d9ebcd)
acatangiu
pushed a commit
that referenced
this pull request
Sep 5, 2024
Backport #5581 into `stable2409` (cc @franciscoaguirre). The dry-run shows in `forwarded_xcms` all the messages in the queues at the time of calling the API. Each time the API is called, the result could be different. You could get messages even if you dry-run something that doesn't send a message, like a `System::remark`. This commit fixes this by clearing the message queues before doing the dry-run, so the only messages left are the ones the users of the API actually care about. Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
acatangiu
pushed a commit
that referenced
this pull request
Sep 5, 2024
Backport #5581 into `stable2407` (cc @franciscoaguirre). The dry-run shows in `forwarded_xcms` all the messages in the queues at the time of calling the API. Each time the API is called, the result could be different. You could get messages even if you dry-run something that doesn't send a message, like a `System::remark`. This commit fixes this by clearing the message queues before doing the dry-run, so the only messages left are the ones the users of the API actually care about. Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
ggwpez
removed
the
A4-needs-backport
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dry-run shows in
forwarded_xcmsall the messages in the queues at the time of calling the API.Each time the API is called, the result could be different.
You could get messages even if you dry-run something that doesn't send a message, like a
System::remark.This PR fixes this by clearing the message queues before doing the dry-run, so the only messages left are the ones the users of the API actually care about.