Disable flaky test #3602
Merged
Disable flaky test #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamaharon
approved these changes
Mar 7, 2024
liamaharon
approved these changes
Mar 7, 2024
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
|
Instead of disabling the test, we should enable logging and see where it hangs/fails. Running this test locally doesn't lead to it stalling. |
|
I think @andresilva is debugging it. The fix can enable the test again. This makes merging really hard. You need to be lucky two times in a row (you get kicked out of the merge queue). |
andresilva
approved these changes
Mar 7, 2024
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Unfortunately, the flakiness wasn't fixed by paritytech#3595. Let's disable the test in the meanwhile since it is hanging on the CI a lot. --------- Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, the flakiness wasn't fixed by #3595. Let's disable the test in the meanwhile since it is hanging on the CI a lot.