[XCM] don't ignore errors

[xlc]

          someone should make a rule to disallow ignoring errors

Originally posted by @xlc in #2405 (comment)

Need to make sure every .map_err(|_| are justified with good reasons.

[bkchr]

map_err is not ignoring the error, it just maps it... as the name is already hinting.

[xlc]

but |_| is ignoring it and it looks like a sad face

[ggwpez]

Should probably still be logged to ease debuggability.

[ayevbeosa]

Hi @xlc, I am interested in working on this, my assumption is for occurrences of .map_err(|_| , it would look like this
.map_err(|e| { log::error!(target: "xcm::pallet_xcm::function_name", "Some description: {:?}", e);

[xlc]

yes

[acatangiu]

Issue is not complete, still many many XCM filters/helpers/matchers/types to add logging to.

[acatangiu]

Everything in

• /~https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/xcm-builder/src/
• /~https://github.com/paritytech/polkadot-sdk/tree/master/cumulus/parachains/runtimes/assets/common/src
• runtime-defined XCM filters/converters (just one example)

should have logging

[ayevbeosa]

Everything in

• /~https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/xcm/xcm-builder/src/
• /~https://github.com/paritytech/polkadot-sdk/tree/master/cumulus/parachains/runtimes/assets/common/src
• runtime-defined XCM filters/converters (just one example)

should have logging

I guess I'd like to complete this till the very end then.

[Krayt78]

@ayevbeosa Is this still being worked on ?

[ayevbeosa]

Yes please