This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Unify RelayChainInterface error handling and introduce async #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skunert
added
B0-silent
bkchr
reviewed
Jan 21, 2022
bkchr
approved these changes
Jan 25, 2022
| @@ -222,6 +218,7 @@ impl TryFrom<&'_ CollationSecondedSignal> for BlockAnnounceData { | |||
| /// chain. If it is at the tip, it is required to provide a justification or otherwise we reject | |||
| /// it. However, if the announcement is for a block below the tip the announcement is accepted | |||
| /// as it probably comes from a node that is currently syncing the chain. | |||
| #[derive(Clone)] | |||
There was a problem hiding this comment.
I was having lifetime issues while moving function calls to the async block in the validate method: /~https://github.com/paritytech/cumulus/pull/909/files#diff-0fe3ce0d7087ba7f979d9065d8d812b23562d2f4ed5341719aa8480dc48c74cdR345
There was a problem hiding this comment.
Ahh I see. Can you then make the handle_empty_block_announce_data async and not have it return a future?
client/pov-recovery/src/lib.rs
Outdated
| }); | ||
|
|
||
| session_index_result | ||
| .and_then(|v| Ok(pending_availability_result?.map(|pa| (pa, v)))) |
There was a problem hiding this comment.
Suggested change
| .and_then(|v| Ok(pending_availability_result?.map(|pa| (pa, v)))) | |
| .and_then(|v| pending_availability_result.map(|pa| (pa, v))) |
There was a problem hiding this comment.
This suggestion does not work here as it changes the return type. However, I tried to improve the readability of this section
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
26 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes more changes in preparation of network communication with the relay chain:
RelayChainInterfacemethods asyncRelayChainErrorwith enum variants for different errorsnew_best_notification_streamto the interface. Over RPC, we only receive the header instead ofBlockImportNotification. In some places we were checking if a new block is the new best. These places now consumenew_best_notification_stream.This PR is not expected to change behaviour.