-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish bundle-stats-cli and parcel-query #9431
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Also this should be just
|
Once these two problems are fixed, it should be good to go 👍 |
RequestTracker: require('@parcel/core/src/RequestTracker.js'), | ||
LMDBCache: require('@parcel/cache/src/LMDBCache.js').LMDBCache, | ||
// $FlowFixMe(incompatible-cast) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added these $FlowFixMe's for cases where there's import type
instead of import typeof
, I was running into some incompatible call errors that I wasn't sure how to resolve..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed a fix for that. The problem was that various values you reexported in deep-imports were actually types that don't actually exist at runtime, which is why flow complained as they aren't actually there.
It's fine to do deep type imports here, because they are erased at build time, so don't refer to the src
folder once published.
↪️ Pull Request
Publishes
bundle-stats-cli
andparcel-query
💻 Examples
🚨 Test instructions
✔️ PR Todo