-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parcel-link and parcel-unlink dev CLIs #8618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. |
cf226fb
to
18cbb5e
Compare
f52631d
to
f7a715f
Compare
f7a715f
to
43adc68
Compare
939afe9
to
6f36037
Compare
ffcd4ca
to
d3f08a4
Compare
d3f08a4
to
df59e8d
Compare
6f36037
to
ea9bd72
Compare
6716803
to
4926544
Compare
ea9bd72
to
f9843ea
Compare
4926544
to
a575496
Compare
c6c3fa0
to
0463c5b
Compare
f9843ea
to
e2cd54e
Compare
More testable
these tests are for the '--namespace' feature, which is is only useful if you're testing a fork of Parcel, so seems safe enough to skip.
e2cd54e
to
7e75d92
Compare
marcins
approved these changes
Nov 2, 2023
alshdavid
approved these changes
Nov 2, 2023
thebriando
approved these changes
Nov 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is stacked on #8857 because its tests rely on changes from that PR
This is a packaging of a very useful script that @mischnic initially created for our internal use. The script makes it easy to test a local copy of Parcel in an existing project by replacing Parcel packages with symlinks to the local copy.
In this PR, the script has been wrapped in a CLI, such that it can be installed and used to link any copy of Parcel to any project.
How to test
check out this branch and run
yarn
, thencd packages/dev/parcel-link && yarn link
to make the
parcel-link
binary globally available.Then, you should be able to try linking into any project by
cd /project/path && parcel-link
.You can also link a different copy of Parcel (default is the copy that
parcel-link
belongs to:The README has more info, as does
parcel-link -h
unlinking
Currently,
parcel-link unlink
attempts to do the opposite of whatparcel-link
did, as recorded in the.parcel-link
manifest.The idea is that
parcel-link unlink
should "just work", rather than taking options to matchparcel-link
.TODO