Retain correct dependency order between imports and reexports without scopehoisting #8591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8560
The problem was that we first collect all imports (and add them to a
requires
array), and then traverse again to do the same for exports.Now, the first traversal covers everything that has to do with dependencies (and thus retains the order), and the second traversal only handles declarations that export local bindings (and can't introduce a new dependency).
The diff makes it look more complicated but I just moved some match armes/if branches to the other loop. There was no other logic change