Include invalidation hash in asset content keys #7526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7524
Previously, the invalidation hash was included in the cache key of the asset itself (so for that
{filePath, committed, contentKey, mapKey, ...}
object), but not incontentKey
(and the other keys). So when changing for example an included file, the new build would overwrite the cache entry for the previous build. This causes the problem described in the issue (when changing an included file, and then changing it back you don't get the original bundle output).I think including the invalidation hash in for
contentKey
is what we want?