-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 --public-url is setted on build and watch #714
Comments
I realise I am defining an output directory, at the moment this flag is being interpreted could be when the default url is getting setted. |
I also think that this behaviour is somewhat unexpected, though I know that changing it would be a breaking change, I think it should be considered. |
I think this is a more a RFC than a bug. But I agree that using anything else than |
Couldn't agree more, for most I would imagine that this is far from the expected behaviour. |
When I work with
parcel index.html
the resulting files have public-url set to./
, when I use build or watch the public url is no longer./
but./build
.Reproducing the error:
/~https://github.com/lrn2prgrm/parcel-bug/tree/master
🎛 Configuration (.babelrc, package.json, cli command)
{
"name": "cli",
"version": "1.0.0",
"license": "MIT",
"scripts": {
"dev-serve": "parcel src/index.html -d build --no-cache",
"watch": "parcel watch src/index.html -d build --no-cache",
"build": "parcel build src/index.html -d build --no-minify --no-cache",
"start": "yarn build"
},
"devDependencies": {
"parcel-bundler": "^1.5.1",
"typescript": "^2.6.2"
}
}
🤔 Expected Behavior
watch and build produced files should be generated as if public url is
./
either with
dev-serve behaves correctly
😯 Current Behavior
watch and build produced files should be generated as if public url is
./build
either with
dev-serve behaves correctly
💁 Possible Solution
No idea about implementation but the code that adds this public url should be found and modified
🌎 Environment
| Software | Version(s)
| Parcel | 1.5.1
| Node | 8.9.2
| Yarn | 1.2.1
| OS | Windows 10 Pro
Found as I closed this issue thanks to niicojs: #706
The text was updated successfully, but these errors were encountered: