Improve general code quality #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ionut-arm
approved these changes
Mar 16, 2021
README.md
Outdated
Comment on lines
22
to
23
| Thanks to Joe Ellis (@joechrisellis) and Ionuț Mihalcea (@ionut-arm) for their early work on the | ||
| crate. |
There was a problem hiding this comment.
At least add yourself as well - "Joe Ellis, Ionut Mihalcea, and Hugues de Valon developed the early prototype...". Seems weird to only mention us two when it's not on your personal repo.
There was a problem hiding this comment.
Alternatively just don't mention anyone - Parsec developers created .... though that's kinda superfluous
There was a problem hiding this comment.
hmm yeah I wanted to credit those involved in this... I will just add them as co-author of this specific commit.
There was a problem hiding this comment.
(I should have done that for the first commit but I forgot)
Comment on lines
+9
to
+14
| let supported_platforms = vec![ | ||
| "x86_64-unknown-linux-gnu".to_string(), | ||
| "aarch64-unknown-linux-gnu".to_string(), | ||
| "armv7-unknown-linux-gnueabi".to_string(), | ||
| "arm-unknown-linux-gnueabi".to_string(), | ||
| ]; |
Comment on lines
+10
to
+11
| env::var("PKCS11_SOFTHSM2_MODULE") | ||
| .unwrap_or_else(|_| "/usr/local/lib/softhsm/libsofthsm2.so".to_string()), |
| use std::thread; | ||
|
|
||
| #[test] | ||
| #[serial] |
There was a problem hiding this comment.
Nice, didn't know about this before
This commit: * uses a ci.sh script to perform all CI tasks * adds cross-compilation logic * improves Slot to integer conversion handling (thanks to @george-hopkins) * adds some deny * implements Copy, Debug, Clone where needed * moves tests to the integration test folder * fixes various lints * adds credit Co-authored-by: George Hopkins <george-hopkins@null.net> Co-authored-by: Joe Ellis <joe.ellis@arm.com> Co-authored-by: Ionut Mihalcea <ionut.mihalcea@arm.com> Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
Signed-off-by: Hugues de Valon <hugues.devalon@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
@george-hopkins)
Co-authored-by: George Hopkins george-hopkins@null.net
Signed-off-by: Hugues de Valon hugues.devalon@arm.com