Add support for Elliptic Curves signing #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
force-pushed
the
add-support-for-ecdsa
branch
from
51b1a8e to
ba42c52
Compare
|
Ha, perfect timing 😄 Thanks for the patch, I was in the process of adding ECC support to Parsec, which means adding ECC support to this crate. I'll be raising some PRs next week for generating the keys - and will have a look at this in the next few days. |
hug-dev
approved these changes
Jun 1, 2021
wiktor-k
force-pushed
the
add-support-for-ecdsa
branch
from
ba42c52 to
064b34a
Compare
This change adds support for retrieving `EC_POINT` attribute from cards as well as `CKM_ECDSA` signing mechanism and the `EC` key type. Signed-off-by: Wiktor Kwapisiewicz <wiktor@metacode.biz>
ionut-arm
reviewed
Jun 1, 2021
ionut-arm
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for retrieving
EC_POINTattribute from cards as well asCKM_ECDSAsigning mechanism and theECkey type.I'm using this patch for OpenPGP signature generation for my small proof of concept: https://gitlab.com/wiktor/pkcs11-openpgp/#pkcs11-tools-for-openpgp and tested getting EC public keys and signing using Yubico 5C with secp256r1 key stored in a PIV applet and generated through
ykman-gui.