Added in_after_callback argument to save_with_version #1371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My application calls
PaperTrail::RecordTrail#save_with_version
in anafter
callback. The version record that this method creates does not record the current changes on the object being tracked. I found the cause in thePaperTrail::Events::Base#load_changes_in_latest_version
method, which only uses@record.saved_changes
when@in_after_callback
is true. Unfortunately I don't currently see a way to make@in_after_callback == true
when usingsave_with_version
.This pull request adds an
in_after_callback
argument to thePaperTrail::RecordTrail#save_with_version
method, to allow the caller to indicate if this method is being called during anafter
callback. The argument defaults tofalse
when not provided.Check the following boxes:
master
(if not - rebase it).Squashed related commits together.code introduces user-observable changes.
and description in grammatically correct, complete sentences.