Support preview releases #698
Conversation
* Add tag support * Allow anything after the version numbers * Adding number version * Update script * Fix
ErikMogensen
requested review from
paolosalvatori and
SeanFeldman
as code owners
(cherry picked from commit e730e10)
|
It's not my intent to stall this PR. Just doesn't feel right to introduce this complexity. Have you excited something like MinVerMinVer? This problem has been solved with tools such as MinVer. |
|
I haven't used Minver. It seems to be a good tool, but it looks to me that it will add complexity in this case since we still have to check if it is a prelease to determine if it should be published to Chocolatey and it requires changing all of the project files and adding one more component. To make changes to the build is time-consuming since a build takes 5 minutes and requires some gitting. That's a great advantage to PowerShell scripts which is just F5 and then it is running and allows debugging. |
|
Manually tweaking the version and figuring out what it should be is complex. This is what MinVer and such already solved a long-time ago if you prefer to do it manually, by all means. |
|
I as I understand it the main feature of Minver is that generates a version number based on previous builds and tags. That is a great feature and not something I intend to replicate. If we had that we could build without having to tag, which would probably be good, but that's not the issue this PR is about. In the code there are two lines of PowerShell code that strips of the prelease label from the version to have a version string that can be used for checking if it is a prelease build and for setting the version number. I am not going to spend more time on this PR, unless someone start paying me for it. |
☝️🙂 |
|
It is worth a try 😉 |
Fixes #697
Since Assembly version and file version don't allow letters this PR adds setting the Informational file version, which allows letters. Then we can have 5.3.4-beta1.