REGR: fix period dtype <-> arrow roundtrip for pyarrow < 4 #45524
Conversation
jorisvandenbossche
added
Regression
| @@ -51,6 +52,12 @@ def make_block( | |||
|
|
|||
| values, dtype = extract_pandas_array(values, dtype, ndim) | |||
|
|
|||
| if klass is ExtensionBlock and is_period_dtype(values.dtype): | |||
There was a problem hiding this comment.
defer to @jbrockmendel but not sure this is the right place for this
There was a problem hiding this comment.
this is fine.
issue a deprecation warning?
There was a problem hiding this comment.
issue a deprecation warning?
For the case we know about (pyarrow), this is already fixed in the latest release. For in general, we might want to raise a warning for any time that klass is specified? So that it always will be inferred from the values (which pyarrow already does by now), and we don't have this issue again when changing Block classes.
Giving the timing of the release, I think we can discuss that in a follow up
|
Is this ready? can we merge and get this backported or move to 1.4.1 before tomorrow morning since if still open and on the 1.4 milestone tomorrow I will not start the release. |
|
@meeseeksdev backport 1.4.x |
…rip for pyarrow < 4
|
Something went wrong ... Please have a look at my logs. |
…arrow < 4 (#45541) Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Closes #45470