Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

no-implicit-dependencies crashes on invalid package.json #3369

Closed
ajafff opened this issue Oct 21, 2017 · 0 comments · Fixed by #3373
Closed

no-implicit-dependencies crashes on invalid package.json #3369

ajafff opened this issue Oct 21, 2017 · 0 comments · Fixed by #3373
Labels
Status: Accepting PRs Type: Bug

Comments

@ajafff
Copy link
Contributor

ajafff commented Oct 21, 2017 •
edited
Loading

no-implicit-dependencies crashes if package.json doesn't contain valid JSON.
It should catch any exception while reading and parsing the file and just treat it as empty.
@ajafff ajafff mentioned this issue Oct 22, 2017
Merged
4 tasks
adidahiya pushed a commit that referenced this issue Oct 23, 2017
@ajafff @adidahiya
no-implicit-dependencies: treat malformed package.json as empty (#3373)
814277f 
[bugfix] `no-implicit-dependencies` don't crash on malformed package.json
Fixes: #3369
HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this issue Apr 9, 2018
@ajafff @HyphnKnight
no-implicit-dependencies: treat malformed package.json as empty (pala…
220766b 
…ntir#3373)

[bugfix] `no-implicit-dependencies` don't crash on malformed package.json
Fixes: palantir#3369
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Status: Accepting PRs Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

no-implicit-dependencies: treat malformed package.json as empty
1 participant
@ajafff