no-implicit-dependencies: treat malformed package.json as empty (#3373)

[bugfix] `no-implicit-dependencies` don't crash on malformed package.json Fixes: #3369
palantir · Oct 23, 2017 · 814277f · 814277f
1 parent 306c1c6
commit 814277f
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 14 deletions.
diff --git a/src/rules/noImplicitDependenciesRule.ts b/src/rules/noImplicitDependenciesRule.ts
@@ -114,20 +114,24 @@ function getDependencies(fileName: string, options: Options): Set<string> {
     const result = new Set<string>();
     const packageJsonPath = findPackageJson(path.resolve(path.dirname(fileName)));
     if (packageJsonPath !== undefined) {
-        // don't use require here to avoid caching
-        // remove BOM from file content before parsing
-        const content = JSON.parse(fs.readFileSync(packageJsonPath, "utf8").replace(/^\uFEFF/, "")) as PackageJson;
-        if (content.dependencies !== undefined) {
-            addDependencies(result, content.dependencies);
-        }
-        if (!options.dev && content.peerDependencies !== undefined) {
-            addDependencies(result, content.peerDependencies);
-        }
-        if (options.dev && content.devDependencies !== undefined) {
-            addDependencies(result, content.devDependencies);
-        }
-        if (options.optional && content.optionalDependencies !== undefined) {
-            addDependencies(result, content.optionalDependencies);
+        try {
+            // don't use require here to avoid caching
+            // remove BOM from file content before parsing
+            const content = JSON.parse(fs.readFileSync(packageJsonPath, "utf8").replace(/^\uFEFF/, "")) as PackageJson;
+            if (content.dependencies !== undefined) {
+                addDependencies(result, content.dependencies);
+            }
+            if (!options.dev && content.peerDependencies !== undefined) {
+                addDependencies(result, content.peerDependencies);
+            }
+            if (options.dev && content.devDependencies !== undefined) {
+                addDependencies(result, content.devDependencies);
+            }
+            if (options.optional && content.optionalDependencies !== undefined) {
+                addDependencies(result, content.optionalDependencies);
+            }
+        } catch {
+            // treat malformed package.json files as empty
         }
     }
 

diff --git a/test/rules/no-implicit-dependencies/default/malformed/package.json b/test/rules/no-implicit-dependencies/default/malformed/package.json
@@ -0,0 +1,3 @@
+{
+    ,
+}
diff --git a/test/rules/no-implicit-dependencies/default/malformed/tets.ts.lint b/test/rules/no-implicit-dependencies/default/malformed/tets.ts.lint
@@ -0,0 +1,2 @@
+import foo from 'foo';
+                ~~~~~ [Module 'foo' is not listed as dependency in package.json]
-Original file line number
+Diff line change
@@ -0,0 +1,3 @@
+    {
+        ,
+    }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		import foo from 'foo';
		~~~~~ [Module 'foo' is not listed as dependency in package.json]