Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix windows paths #108

Merged
merged 1 commit into from
Nov 8, 2018
Merged

fix windows paths #108

merged 1 commit into from
Nov 8, 2018

Conversation

llogiq
Copy link
Collaborator

@llogiq llogiq commented Oct 24, 2018

This fixes #107

paholg
paholg approved these changes Oct 24, 2018
View reviewed changes
Copy link
Owner

@paholg paholg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like build is failing for unrelated reasons that I thought I had fixed... LGTM

droundy
droundy approved these changes Oct 25, 2018
View reviewed changes
Copy link

@droundy droundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems kind of ugly, but the simplest way to handle this. I wish you could use std::path::Path::join for something like this.

@paholg paholg merged commit 11b5193 into master Nov 8, 2018
@mmatous mmatous mentioned this pull request Aug 26, 2019
Closed
@MingweiSamuel MingweiSamuel mentioned this pull request Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paholg paholg paholg approved these changes

@droundy droundy droundy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails on windows when compiling with wasm-pack
3 participants
@llogiq @droundy @paholg