[#175059122] Centralise config read #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected stories
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
- Coverage 83.94% 83.85% -0.10%
==========================================
Files 44 45 +1
Lines 1489 1505 +16
Branches 124 125 +1
==========================================
+ Hits 1250 1262 +12
- Misses 234 238 +4
Partials 5 5
Continue to review full report at Codecov.
|
|
lgtm, if you handle the FIXMEs we can proceed and merge it |
AleDore
reviewed
Oct 5, 2020
|
lgtm, why draft ? |
DeleteUserDataActivity/index.ts
Outdated
Comment on lines
19
to
22
| const cosmosDbName = config.COSMOSDB_NAME; | ||
|
|
||
| const messagesContainer = cosmosdbClient | ||
| .database(cosmosDbName) |
There was a problem hiding this comment.
Can we use directly the config value?
Suggested change
| const cosmosDbName = config.COSMOSDB_NAME; | |
| const messagesContainer = cosmosdbClient | |
| .database(cosmosDbName) | |
| const messagesContainer = cosmosdbClient | |
| .database(config.COSMOSDB_NAME) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
utils/configmodule which aims to be the unique interface for application configuration.Every place in which the application used to directly access env variable has been refactored to use this module instead.