Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#174947061] Externalize token name attribute #88

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

AleDore
Copy link
Contributor

@AleDore AleDore commented Sep 24, 2020

This PR is useful for externalize Token Name attribute, defined in ADB2C

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020

Codecov Report

Merging #88 into master will decrease coverage by 2.68%.
The diff coverage is 76.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   86.62%   83.94%   -2.69%     
==========================================
  Files          39       44       +5     
  Lines        1249     1489     +240     
  Branches       88      124      +36     
==========================================
+ Hits         1082     1250     +168     
- Misses        166      234      +68     
- Partials        1        5       +4     
Impacted Files Coverage Δ
SendUserDataDeleteEmailActivity/handler.ts 37.50% <37.50%> (ø)
DeleteUserDataActivity/utils.ts 34.21% <50.00%> (ø)
utils/conversions.ts 81.81% <58.33%> (-6.82%) ⬇️
GetUser/handler.ts 90.27% <63.63%> (-1.91%) ⬇️
ExtractUserDataActivity/handler.ts 77.30% <70.96%> (-0.71%) ⬇️
UserDataDeleteOrchestrator/handler.ts 90.55% <83.33%> (-2.24%) ⬇️
DeleteUserDataActivity/backupAndDelete.ts 92.85% <87.09%> (ø)
GetProfileActivity/handler.ts 90.69% <90.69%> (ø)
GetServices/handler.ts 84.84% <94.73%> (-0.34%) ⬇️
CreateService/handler.ts 85.18% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c1bcb...39e8164. Read the comment docs.

@pagopa-github-bot
Copy link
Contributor

Affected stories

  • ⚙️ #174947061: Modificare il formato del custom attribute per il Token Name

Generated by 🚫 dangerJS

@gunzip gunzip merged commit c7b7513 into master Sep 24, 2020
@gunzip gunzip deleted the 174947061_externalize_token_name_attribute branch September 24, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants