Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#17482372] Add token name to GetUser from Azure ADB2C #85

Merged
merged 4 commits into from
Sep 18, 2020

Conversation

AleDore
Copy link
Contributor

@AleDore AleDore commented Sep 18, 2020

This PR is useful to retrieve custom extension property token_name from Azure AD B2C, while calling GetUser API. Property value is also mapped into UserInfo API model in order to make possible info's propagation to io-functions-services.

Edit: Fix on token attribute's naming

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2020

Codecov Report

Merging #85 into master will decrease coverage by 1.58%.
The diff coverage is 81.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   86.62%   85.04%   -1.59%     
==========================================
  Files          39       41       +2     
  Lines        1249     1371     +122     
  Branches       88      114      +26     
==========================================
+ Hits         1082     1166      +84     
- Misses        166      200      +34     
- Partials        1        5       +4     
Impacted Files Coverage Δ
DeleteUserDataActivity/utils.ts 34.21% <50.00%> (ø)
utils/conversions.ts 81.81% <58.33%> (-6.82%) ⬇️
GetUser/handler.ts 90.27% <63.63%> (-1.91%) ⬇️
ExtractUserDataActivity/handler.ts 77.30% <70.96%> (-0.71%) ⬇️
DeleteUserDataActivity/backupAndDelete.ts 92.85% <87.09%> (ø)
GetServices/handler.ts 84.84% <94.73%> (-0.34%) ⬇️
CreateService/handler.ts 85.18% <100.00%> (ø)
CreateUser/handler.ts 86.84% <100.00%> (-1.80%) ⬇️
GetService/handler.ts 86.95% <100.00%> (ø)
GetUserDataProcessingActivity/handler.ts 90.90% <100.00%> (-0.21%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419bc30...5b351ab. Read the comment docs.

@gunzip
Copy link
Contributor

gunzip commented Sep 18, 2020

it looks like there are some conflicts

@pagopa-github-bot
Copy link
Contributor

Affected stories

Generated by 🚫 dangerJS

@gunzip gunzip merged commit 618aff4 into master Sep 18, 2020
@gunzip gunzip deleted the 174823724_get_token_name_from_azure_AD branch September 18, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants