[#174823724] Add token name to GetUser from Azure ADB2C #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected stories
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
- Coverage 86.62% 85.04% -1.59%
==========================================
Files 39 41 +2
Lines 1249 1371 +122
Branches 88 114 +26
==========================================
+ Hits 1082 1166 +84
- Misses 166 200 +34
- Partials 1 5 +4
Continue to review full report at Codecov.
|
gunzip
reviewed
Sep 18, 2020
Comment on lines
+220
to
+221
| adb2User[ | ||
| `adb2User.extension_${adb2cCredentials.clientId}_token_name` |
There was a problem hiding this comment.
what if the user does not have this attribute ? (may you try to delete ti into the ADB2C and call GetUser?)
There was a problem hiding this comment.
I think that many users will not have this attribute on ADB2C. In that case token_name should be null and it will remain null until we add it on Active Directory. Why should we delete the user if it does not have token_name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is useful to retrieve custom extension property
token_namefrom Azure AD B2C, while callingGetUserAPI. Property value is also mapped intoUserInfoAPI model in order to make possible info's propagation to io-functions-services.