Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOCIT-26] Updated io-functions-commons and ts-commons #190

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

arcogabbo
Copy link
Contributor

List of Changes

Updated @pagopa/io-functions-commons and @pagopa/ts-commons
Repaired some tests after the update

Motivation and Context

Updated models

How Has This Been Tested?

Build, test and linting OK
The entire flows of profile data DOWNLOAD and DELETE has been tested through the io-mock project and it has been verified that the new variables were present in the data downloaded.

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@arcogabbo arcogabbo requested a review from a team as a code owner August 22, 2022 09:01
@arcogabbo arcogabbo requested review from Garma00 and fabriziopapi and removed request for a team August 22, 2022 09:01
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

@BurnedMarshal
Copy link
Contributor

@gquadrati could you confirm that the unit test changes were as expected?

@gquadrati
Copy link
Contributor

@gquadrati could you confirm that the unit test changes were as expected?

Yes, I confirm

@BurnedMarshal BurnedMarshal merged commit 746771d into master Aug 23, 2022
@BurnedMarshal BurnedMarshal deleted the IOCIT-26 branch August 23, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants