-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#175594485] Fix healthcheck gate deploy pipeline #105
Conversation
pasqualedevita
commented
Nov 5, 2020
•
edited
Loading
edited
- add new parameter containerInstanceResourceGroup
- add checks if exists target vnet and subnet to avoid to create new vnet or subnet
Affected stories
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=======================================
Coverage 84.20% 84.20%
=======================================
Files 49 49
Lines 1665 1665
Branches 124 124
=======================================
Hits 1402 1402
Misses 258 258
Partials 5 5 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm cc @balanza
# the resource group must be the same where vnet is created | ||
- name: 'containerInstanceResourceGroup' | ||
type: string | ||
default: 'io-p-rg-common' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we get this value from the environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
az network vnet subnet list
requires resource group to list subnets, so we can't get values from other resources.
I don't think that we'll changes these values often.
# the resource group must be the same where vnet is created
- name: 'containerInstanceResourceGroup'
type: string
default: 'io-p-rg-common'
# attached vnet to the container instance
- name: 'containerInstanceVNet'
type: string
default: 'io-p-vnet-common'
# container instance subnet
- name: 'containerInstanceSubnet'
type: string
default: 'azure-devops'