Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#175594485] Fix healthcheck gate deploy pipeline #105

Merged
merged 2 commits into from
Nov 5, 2020

Conversation

pasqualedevita
Copy link
Member

@pasqualedevita pasqualedevita commented Nov 5, 2020

  • add new parameter containerInstanceResourceGroup
  • add checks if exists target vnet and subnet to avoid to create new vnet or subnet

@pasqualedevita pasqualedevita marked this pull request as ready for review November 5, 2020 12:37
@pagopa-github-bot
Copy link
Contributor

pagopa-github-bot commented Nov 5, 2020

Affected stories

  • 🐞 #175594485: fix resource group healthcheck gate deploy pipeline

Generated by 🚫 dangerJS

@codecov-io
Copy link

codecov-io commented Nov 5, 2020

Codecov Report

Merging #105 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   84.20%   84.20%           
=======================================
  Files          49       49           
  Lines        1665     1665           
  Branches      124      124           
=======================================
  Hits         1402     1402           
  Misses        258      258           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ba69d7...4260a7f. Read the comment docs.

Copy link
Contributor

@gunzip gunzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm cc @balanza

# the resource group must be the same where vnet is created
- name: 'containerInstanceResourceGroup'
type: string
default: 'io-p-rg-common'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we get this value from the environment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

az network vnet subnet list requires resource group to list subnets, so we can't get values from other resources.

I don't think that we'll changes these values often.

  # the resource group must be the same where vnet is created
  - name: 'containerInstanceResourceGroup'
    type: string
    default: 'io-p-rg-common'
  # attached vnet to the container instance
  - name: 'containerInstanceVNet'
    type: string
    default: 'io-p-vnet-common'
  # container instance subnet
  - name: 'containerInstanceSubnet'
    type: string
    default: 'azure-devops'

@gunzip gunzip merged commit 0fb2410 into master Nov 5, 2020
@gunzip gunzip deleted the 175594485-fix-rg-healthcheck branch November 5, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants