feat(epsaqu scheme) and refactor mup3d #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a user-defined change in conc between tsteps. turned off for tests at the moment. Added run_cmd func to run from terminal
…orking properly needs fixing
…orking properly needs fixing
… update notebooks and tests to work with this module
|
Merging and updating main to release alpha in PyPi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(epsaqu scheme) and refactor mup3d
Added scheme to skip reactions in cells when change in concentration between transport time steps is less than a
epsaquthreshold. The scheme is working but needs more testing. By default is turned off and there is no option to turned it on yet.In addition, the class (
mup3d) that writes the model files has been moved into a separate module.Tests are running.